Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Commit fa2bfe0cd4eecd1d06d9ca548e4cb852aad67053 kills my build on openSUSE #3154 #3155

Closed
wants to merge 4 commits into from
Closed

fix: Commit fa2bfe0cd4eecd1d06d9ca548e4cb852aad67053 kills my build on openSUSE #3154 #3155

wants to merge 4 commits into from

Conversation

Eckeneckepen
Copy link

  1. Interrupt configure if no path is found.
  2. Call sysconfig.get_path() depending if scheme deb_system exists.

@Eckeneckepen
Copy link
Author

The bullseye test failed, because the python files are installed to
install -o root -d -m 0755 /__w/linuxcnc/linuxcnc/debian/tmp/usr/lib/python3.9/site-packages

but are expected by debian/linuxcnc.install.in in usr/lib/python3.

Does the test container provide deb_system? The installation path seems to be from posix_prefix.

The log says that ubuntu is used:
2024-10-16T19:28:48.8051261Z Ubuntu
2024-10-16T19:28:48.8051502Z 24.04.1

Is Ubuntu 24.04.1 compatible to Debian 11?
Do Debian 11 and Ubuntu 24.04.1 support already the scheme deb_system?

@Eckeneckepen
Copy link
Author

Checked the log of commit 062589e control.c: expand clipping of motion.adaptive-feed to +/-MAX_FEED_OVERRIDE
https://github.com/LinuxCNC/linuxcnc/actions/runs/11374046558/job/31641934780

bullseye does not seem to support deb_system. Same error i have on suse:

2024-10-16T21:23:27.7885271Z checking for site-package location... Traceback (most recent call last):
2024-10-16T21:23:27.7887675Z   File "<string>", line 1, in <module>
2024-10-16T21:23:27.7888769Z   File "/usr/lib/python3.9/sysconfig.py", line 523, in get_path
2024-10-16T21:23:27.7889842Z     return get_paths(scheme, vars, expand)[name]
2024-10-16T21:23:27.7890653Z   File "/usr/lib/python3.9/sysconfig.py", line 513, in get_paths
2024-10-16T21:23:27.7891191Z     return _expand_vars(scheme, vars)
2024-10-16T21:23:27.7891716Z   File "/usr/lib/python3.9/sysconfig.py", line 177, in _expand_vars
2024-10-16T21:23:27.7892316Z     for key, value in _INSTALL_SCHEMES[scheme].items():
2024-10-16T21:23:27.7892847Z KeyError: 'deb_system'

Carsten/Eckeneckepen added 2 commits October 17, 2024 22:51
fix: Commit fa2bfe0 kills my build on openSUSE LinuxCNC#3154
7adb947 
Consider Debian 11 for SITEPY.
fix: Commit fa2bfe0 kills my build on openSUSE LinuxCNC#3154
5001ccb 
Debian uses dist-packages instead of site-packages.
@smoe
Copy link
Contributor

smoe commented Oct 18, 2024

Looks good to me. No idea what had changed where but our builds now fail without that adaptation. @petterreinholdtsen ?

@andypugh
Copy link
Collaborator

I have reverted my original attempt to fix the problems caused by deleting distutils.

Maybe somebody else knows how to do it properly?

@smoe
Copy link
Contributor

smoe commented Oct 19, 2024

Maybe we can have debian/configure remove distutils only for the latest versions of Debian?

@petterreinholdtsen
Copy link
Collaborator

petterreinholdtsen commented Oct 19, 2024 via email

@Eckeneckepen Eckeneckepen mentioned this pull request Oct 20, 2024
Merged
@Eckeneckepen Eckeneckepen deleted the branch LinuxCNC:master October 20, 2024 18:16
@Eckeneckepen Eckeneckepen deleted the master branch October 20, 2024 18:16
@Eckeneckepen Eckeneckepen restored the master branch October 20, 2024 18:19
@Eckeneckepen Eckeneckepen reopened this Oct 20, 2024
@Eckeneckepen Eckeneckepen deleted the master branch October 20, 2024 19:57
@petterreinholdtsen
Copy link
Collaborator

Thank you for useful ideas. I am testing some of these ideas in my draft patch now.

petterreinholdtsen added a commit to petterreinholdtsen/linuxcnc that referenced this pull request Oct 20, 2024
@petterreinholdtsen
Dropped use of depricated python3-setuptools / distutils.
c1c5283 
Make sure sysconfig.get_path("platlib") return correct path on Debian
and Ubuntu systems, where /usr/lib/ should be used over
/usr/local/lib.

Based on e2c10a8 by Andy Pugh and
pull request LinuxCNC#3155 by Eckeneckepen.

Fixes Debian issue #1080668.
petterreinholdtsen added a commit to petterreinholdtsen/linuxcnc that referenced this pull request Oct 21, 2024
@petterreinholdtsen
Dropped use of depricated python3-setuptools / distutils.
c8103d0 
Make sure sysconfig.get_path("platlib") return correct path on Debian
and Ubuntu systems, where /usr/lib/ should be used over
/usr/local/lib.

Based on e2c10a8 by Andy Pugh and
pull request LinuxCNC#3155 by Eckeneckepen.

Fixes Debian issue #1080668.
petterreinholdtsen added a commit to petterreinholdtsen/linuxcnc that referenced this pull request Oct 21, 2024
@petterreinholdtsen
Dropped use of depricated python3-setuptools / distutils.
33a1bc0 
Make sure sysconfig.get_path("platlib") return correct path on Debian
and Ubuntu systems, where /usr/lib/ should be used over
/usr/local/lib.

Based on e2c10a8 by Andy Pugh and
pull request LinuxCNC#3155 by Eckeneckepen.

Fixes Debian issue #1080668.
petterreinholdtsen added a commit to petterreinholdtsen/linuxcnc that referenced this pull request Oct 21, 2024
@petterreinholdtsen
Dropped use of depricated python3-setuptools / distutils.
1709059 
Make sure sysconfig.get_path("platlib") return correct path on Debian
and Ubuntu systems, where /usr/lib/ should be used over
/usr/local/lib.

Based on e2c10a8 by Andy Pugh and
pull request LinuxCNC#3155 by Eckeneckepen.

Fixes Debian issue #1080668.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eckeneckepen @smoe @andypugh @petterreinholdtsen