Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian - netcat build deps #2195

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

smoe
Copy link
Contributor

@smoe smoe commented Dec 8, 2022

Apparently the former netcat package was renamed to netcat-traditional (https://tracker.debian.org/pkg/netcat).

@petterreinholdtsen
Copy link
Collaborator

petterreinholdtsen commented Dec 9, 2022 via email

@smoe smoe marked this pull request as draft December 15, 2022 14:38
@petterreinholdtsen
Copy link
Collaborator

@smoe When do you plan to complete this draft patch?

@smoe smoe marked this pull request as ready for review December 19, 2022 11:45
@smoe
Copy link
Contributor Author

smoe commented Dec 19, 2022

Done. Thanks for pushing me to push. On a sidenote - did you find where netcat is used during the build process?

@petterreinholdtsen
Copy link
Collaborator

petterreinholdtsen commented Dec 19, 2022 via email

@petterreinholdtsen
Copy link
Collaborator

I tested build without netcat, only to discover nc is used by several tests, for example tests/linuxcncrsh-tcp/.

@petterreinholdtsen petterreinholdtsen merged commit 2c085f1 into LinuxCNC:2.9 Dec 20, 2022
@smoe
Copy link
Contributor Author

smoe commented Dec 20, 2022

Are we respecting the DEB_BUILD_OPTIONS=nocheck to warrant the <!nocheck> for clarity? https://wiki.debian.org/BuildProfileSpec

@smoe
Copy link
Contributor Author

smoe commented Dec 20, 2022

What came to mind was that we could have an RTAI build profile and use that to substitute what debian/configure is addressing today.

@petterreinholdtsen
Copy link
Collaborator

petterreinholdtsen commented Dec 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants