Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLD - Fix LS QR Code integration test #8212

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

LLD - Fix LS QR Code integration test #8212

wants to merge 2 commits into from

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 25, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

I fixed the integration test for QR Code sync flow on LLD.
I also fixed async/await usage on Ledger Key Ring Protocol libraries

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Oct 25, 2024
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 25, 2024 5:32pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:32pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:32pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:32pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:32pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 25, 2024
@KVNLS KVNLS marked this pull request as ready for review October 25, 2024 17:01
@KVNLS KVNLS requested review from a team as code owners October 25, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant