Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ACRE): messageSign correctly sends appName and dependencies params to the connect action #8209

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Oct 25, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests. Tested manually as we cannot test connect app automatically
  • Impact of the changes:
    • ACRE messageSign

πŸ“ Description

messageSign used in the custom ACRE handlers now correctly passes appName and dependencies params to the connect action

I've also updated the lib and added a missing signIn handler for ACRE while testing everything with the app

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this Oct 25, 2024
@Justkant Justkant requested review from a team as code owners October 25, 2024 13:14
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 25, 2024 3:43pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 3:43pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 3:43pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 3:43pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 3:43pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants