-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restricted strategy list #841
base: slashing-magnitudes
Are you sure you want to change the base?
feat: restricted strategy list #841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly want some more test coverage
bytes32 operatorSetKey = _encodeOperatorSet(operatorSet); | ||
|
||
// Assert that the provided strategies are all whitelisted for the given operator set. | ||
require(avsDirectory.isOperatorSetStrategyBatch(operatorSet, params.strategies), InvalidStrategy()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not have this method accept an operator set as an argument and fetch strategies from the AVSD? That seems far preferable to passing in an array of strategies here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.