feat: restricted strategy list #841
Open
+225
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
commented
Oct 17, 2024
ypatil12
reviewed
Oct 17, 2024
ypatil12
approved these changes
Oct 21, 2024
wadealexc
reviewed
Oct 21, 2024
| bytes32 operatorSetKey = _encodeOperatorSet(operatorSet); | ||
|
|
||
| // Assert that the provided strategies are all whitelisted for the given operator set. | ||
| require(avsDirectory.isOperatorSetStrategyBatch(operatorSet, params.strategies), InvalidStrategy()); |
There was a problem hiding this comment.
Can we not have this method accept an operator set as an argument and fetch strategies from the AVSD? That seems far preferable to passing in an array of strategies here.
wadealexc
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.