Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align environments #794

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Conversation

MinisculeTarantula
Copy link
Collaborator

feat: add checker, improve configs, cleanup

  • add Current_Config_Check.s.sol that checks the active governance config

  • fix configs by adding more addresses + renaming for clarity

  • delete (apparently) unused files

- add Current_Config_Check.s.sol that checks the active governance config

- fix configs by adding more addresses + renaming for clarity

- delete (apparently) unused files
@MinisculeTarantula MinisculeTarantula marked this pull request as draft October 3, 2024 21:20
@MinisculeTarantula MinisculeTarantula marked this pull request as ready for review October 8, 2024 18:33
@MinisculeTarantula
Copy link
Collaborator Author

Update:
This PR could likely use more improvement, but is in a place where I believe it is additive + fairly well-formed, so I am marking it as ready for review, but not explicitly requesting review yet.

Comment on lines +1 to +4
// SPDX-License-Identifier: BUSL-1.1
pragma solidity ^0.8.12;

import "./Deploy_From_Scratch.s.sol";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this file has a ton of duplicated code right now. ideally most of it would be de-duplicated!

script is still broken, details still need figuring out
more clearly and accurately describe end-state of governance with Protocol Council

add simulation of timelock actions

split simulation into smaller logical pieces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants