test: Fork Integration Testing refactor #433

8sunyuan · 2024-02-12T19:41:23Z

With the different upgrade paths between Goerli and Mainnet, this is an attempt at having more upgrade testing by using the utils parser ExistingDeploymentParser and deploying in IntegrationDeployer.setUp() depending on the chainid that tests are being run on.

To run upgrade integration tests

Setup anvil node
anvil -f $RPC_GOERLI
Run integration tests
forge test --match-contract Integration -f http://127.0.0.1:8545

* Fix: flaky integration tests (#384) * feat: strat settings * Fix: flaky integration tests (#384) * feat: strat settings * feat: withdrawalDelayBlocks per strategy * fix: set deprecated storage to private * fix: pr review changes * fix: require string * docs: updated * refactor: rename creditTransfersDisabled * fix: doc typos * docs: add new methods and fix formatting * fix: nits and getWithdrawals view * docs: add link --------- Co-authored-by: Yash Patil <40046473+ypatil12@users.noreply.github.com> Co-authored-by: wadealexc <pragma-services@proton.me>

* fix: add contract size check * fix: ignore harness build size

* refactor: initial draft * fix: revert require chages * fix: small nits

* test: added back avsRegistration tests * fix: fuzz runs 4096 * fix: broken fuzz test

* init commit * updated testFullWithdrawalFlow to deneb spec * added two proof paths * added both capella and deneb testS * added testFullWithdrawalFlowCapellaWithdrawalAgainstDenebRoot * added event * fixed storage gap * uncommented testsg * fix: remove line * fixed tesst * added a setter in the EPM for deneForkTimetamp * tests still broken * cleanup * added modifier * fixing tests * tests working * added tests * comments * fixed failing test * fix flaky test * removed modifier --------- Co-authored-by: gpsanant <gpsanant@gmail.com>

* feat: simplify fork timestamp setting logic * test: fix tests to account for only setting timestamp once --------- Co-authored-by: wadealexc <pragma-services@proton.me>

* Create GoerliUpgrade2.s.sol * preprod deploy * Update GV2_preprod_deployment_2024_30_1.json * nit: comments * avs directory already deployed * preprod deploy

warnings were for unused or shadowed variables, or functions that could have stricter mutability

This reverts commit c3d7bff.

* fix: fixed comment * fix: removed dead space * fix: removed extraneous the * fix: edited another comment

* fix: try installing solc-select * fix: addShares selector

This provides additional signature replay protection for the `StrategyManager.depositIntoStrategyWithSignature` method Specifically, it addresses the issue outlined in https://mirror.xyz/curiousapple.eth/pFqAdW2LiJ-6S4sg_u1z08k4vK6BCJ33LcyXpnNb8yU where some ERC1271 wallets might be vulnerable to "replays" of signatures While the theoretical "damage" would be ~zero (allowing someone to deposit and credit the deposit to a user), adding this field to the typehash seems to be best practice, at least.

* fix: updated doc * fix: changed more incorrect references fo verifyBalanceUpdates * fix: changed more incorrect references fo verifyBalanceUpdates * fix: fixed image * fix: fixed incorrect comment * docs: fix formatting --------- Co-authored-by: wadealexc <pragma-services@proton.me>

* feat: slight refactor to make better use of strategybase hooks * docs: add clarifying comment

this should be MIT licensed; looks like this was missed

wadealexc

Would be nice to have something that can target mainnet, if possible

wadealexc · 2024-02-12T19:49:26Z

Would be nice to have something that can target mainnet, if possible

Wait nvm there's a setupMainnet method...

edit: oh, but it's not impled yet. okay!

seems like a great starting point!

wadealexc · 2024-02-12T19:50:56Z

src/test/integration/IntegrationDeployer.t.sol

+        } else if (block.chainid == 31337) {
+            _setUpLocal();
+        } else {
+            revert();


Probably good to have a message here, otherwise this would be a meganightmare to debug

8sunyuan · 2024-02-12T19:51:50Z

Would be nice to have something that can target mainnet, if possible

Wait nvm there's a setupMainnet method...

Yeah not sure if this is the best place/method to do the upgrade testing so haven't added that in yet. But it made the most sense as there are no mocks setup(outside of beacon stuff) and this will make us take more advantage of our integration testing.

ypatil12

Awesome start! I think there are two parts to this idea of integration tests post-upgrade

Normal interaction on M1 -> Upgrade -> Continue interaction on M2
Upgrade, and ensure that all interaction on M1 can be done on M2

I think this framework does 2, but not necessarily 1? Couple of example scenarios:

queueing a withdrawal on M1 and completing on M2 (tested via WithdrawalMigration.t.sol)
depositing on M1 and then doing the entire LST lifecycle on M2 (delegate, queue, complete)
creating a pod in M1 and pointing WC and then going through the entire pod lifecycle on M2 (verifying WC, balance updates, partial/full withdrawals)
setting an admin var in M1 and then resetting on M2

For 2, I think the main things we should test are normal interaction, which we can easily do with this framework and the already written integration tests, and setting all the admin variables, which could catch the setting of withdrawalDelayBlocks

ypatil12

Also, think we should update the CI to run the integration and off of a fork in addition to the local execution!

olarithecreator · 2024-02-20T11:00:59Z

just read through this!!, very awesome

ypatil12 and others added 27 commits January 2, 2024 16:45

Fix: Update registration documentation & type hash (#383)

97ccd44

fix: update forge CI to include contract size checks (#402)

3e67cd3

* fix: add contract size check * fix: ignore harness build size

refactor: decouple AVS<>Operator mapping from DelegationManager (#403)

fcb32f5

* refactor: initial draft * fix: revert require chages * fix: small nits

fix: operator<>AVS mapping tests (#407)

2376405

* test: added back avsRegistration tests * fix: fuzz runs 4096 * fix: broken fuzz test

docs: add docs for AVSDirectory (#408)

66ace9b

Feat: Add events for beacon chain balance updates & move deposit event

db70bb2

script update (#412)

7257364

fix: middleware script (#414)

0d1008b

feat: simplify fork timestamp setting logic (#416)

f2089af

* feat: simplify fork timestamp setting logic * test: fix tests to account for only setting timestamp once --------- Co-authored-by: wadealexc <pragma-services@proton.me>

Goerli implementation script (#413)

20c06b2

* Create GoerliUpgrade2.s.sol * preprod deploy * Update GV2_preprod_deployment_2024_30_1.json * nit: comments * avs directory already deployed * preprod deploy

chore: fix numerous compiler warnings from script + test files (#419)

a5a3b05

warnings were for unused or shadowed variables, or functions that could have stricter mutability

fixed comment

c3d7bff

Revert "fixed comment"

2071ffa

This reverts commit c3d7bff.

Fixed comments (#422)

607f69a

* fix: fixed comment * fix: removed dead space * fix: removed extraneous the * fix: edited another comment

feat: view func for avssync (#423)

5b15e1e

fix: failing certora-ci (#410)

7511559

* fix: try installing solc-select * fix: addShares selector

Testnet Deploy (#425)

3fad45f

feat: slight refactor to make better use of strategybase hooks (#428)

700f186

* feat: slight refactor to make better use of strategybase hooks * docs: add clarifying comment

test: unit tests for strat config (#426)

531cdff

fix: use correct license (#431)

6639334

this should be MIT licensed; looks like this was missed

docs: update README to point to deployment info (#432)

40b09ea

test: add chainid specific setups

8a47ed2

test: mainnet deploy setup

a3ee199

8sunyuan marked this pull request as draft February 12, 2024 19:41

wadealexc reviewed Feb 12, 2024

View reviewed changes

8sunyuan added 2 commits February 12, 2024 17:33

feat: add shadow fork tests to ci

69f4e3b

fix: try fixing secrets

cd55a2e

ypatil12 reviewed Feb 13, 2024

View reviewed changes

wadealexc force-pushed the m2-mainnet-fixes branch from 17b5dd8 to 4ec523c Compare February 16, 2024 15:38

Base automatically changed from m2-mainnet-fixes to m2-mainnet February 16, 2024 16:37

chore: folder cleanup

39c0fb5

8sunyuan closed this Mar 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Fork Integration Testing refactor #433

test: Fork Integration Testing refactor #433

8sunyuan commented Feb 12, 2024

wadealexc left a comment

wadealexc commented Feb 12, 2024 •

edited

Loading

wadealexc Feb 12, 2024

8sunyuan commented Feb 12, 2024

ypatil12 left a comment •

edited

Loading

ypatil12 left a comment

olarithecreator commented Feb 20, 2024

test: Fork Integration Testing refactor #433

test: Fork Integration Testing refactor #433

Conversation

8sunyuan commented Feb 12, 2024

wadealexc left a comment

Choose a reason for hiding this comment

wadealexc commented Feb 12, 2024 • edited Loading

wadealexc Feb 12, 2024

Choose a reason for hiding this comment

8sunyuan commented Feb 12, 2024

ypatil12 left a comment • edited Loading

Choose a reason for hiding this comment

ypatil12 left a comment

Choose a reason for hiding this comment

olarithecreator commented Feb 20, 2024

wadealexc commented Feb 12, 2024 •

edited

Loading

ypatil12 left a comment •

edited

Loading