Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate broken rule and add a new one #245

Merged
merged 1 commit into from
Oct 13, 2023
Merged

deprecate broken rule and add a new one #245

merged 1 commit into from
Oct 13, 2023

Commits on Oct 13, 2023

  1. deprecate broken rule and add a new one 

    Remove the `totalSharesGeqSumOfShares` invariant, since the way we are enforcing this is now split between the StrategyManager + DelegationManager (rather than being solely enforced by the StrategyManager). Add  a new `newSharesIncreaseTotalShares` rule in its place, which verifies the modified behavior around share changes, and in particular verifies that the StrategyManager still exhibits the same behavior as before, when considered in isolation of the DelegationManager (i.e. ignoring the new `removeShares` + `addShares` functions)
    @ChaoticWalrus
    ChaoticWalrus committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    34abc64 View commit details
    Browse the repository at this point in the history