Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests that were failing due to deleted slasher checks #243

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

wadealexc
Copy link
Collaborator

Removes tests that are now failing because we got rid of "onlyNotFrozen" et al.

Also fixes broken EigenPod test. The test was broken because it was using the wrong value to calculate restaked balance after verifying withdrawal credentials.

I fixed it by just removing the line entirely because, as it turns out, the helper function used to deploy the pod and prove credentials also has a test for the exact same thing, except it uses the correct value.

Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR seems good!

@ChaoticWalrus ChaoticWalrus merged commit 74460e2 into master Oct 13, 2023
12 of 13 checks passed
@ChaoticWalrus ChaoticWalrus deleted the alex/fix-failing-slasher-tests branch October 13, 2023 17:38
@ChaoticWalrus ChaoticWalrus mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants