-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IndexRegistry Tests #242
IndexRegistry Tests #242
Conversation
ef4bb69
to
be726a2
Compare
Yeah nice call out on the struct, do you think it should be renamed to something more generic if it is going to stay overloaded? |
My preference is to separate the struct out into two, as long as there is not a large number of breaking changes off-chain. cc @gpsanant @stevennevins |
I would defer to what @gpsanant thinks here since he's more aware of what dependencies exist there atm |
I like this suggestion, and had also previously called this usage out as inconsistent. There's notes in the comments but having different structs would probably be clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Nice work.
GlobalIndexUpdate
eventIn terms of readability, we overload the
OperatorIndexUpdate
struct such that the index represents different values in different contexts. Might be a good idea to separate this struct out into two for operator index updates and quorum updates.