IndexRegistry Tests

[ypatil12]

• Adds unit/fuzz tests for registration, reregistration, and getters
• Remove stale GlobalIndexUpdate event

In terms of readability, we overload the OperatorIndexUpdate struct such that the index represents different values in different contexts. Might be a good idea to separate this struct out into two for operator index updates and quorum updates.

[stevennevins]

Yeah nice call out on the struct, do you think it should be renamed to something more generic if it is going to stay overloaded?

[ypatil12]

Yeah nice call out on the struct, do you think it should be renamed to something more generic if it is going to stay overloaded?

My preference is to separate the struct out into two, as long as there is not a large number of breaking changes off-chain. cc @gpsanant @stevennevins

[stevennevins]

Yeah nice call out on the struct, do you think it should be renamed to something more generic if it is going to stay overloaded?

My preference is to separate the struct out into two, as long as there is not a large number of breaking changes off-chain. cc @gpsanant @stevennevins

I would defer to what @gpsanant thinks here since he's more aware of what dependencies exist there atm

[ChaoticWalrus]

My preference is to separate the struct out into two, as long as there is not a large number of breaking changes off-chain. cc @gpsanant @stevennevins

I like this suggestion, and had also previously called this usage out as inconsistent. There's notes in the comments but having different structs would probably be clearer.
I'd suggest making this as a separate PR on top of this PR -- you can try implementing quickly + see what it breaks in the on-chain code. IDK about downstream/off-chain dependencies, but if it's a separate PR then we at least have the option hold off on merging just that change.

[ChaoticWalrus]

Looks really good! Nice work.