Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More prover fixes + added rules #236

Merged
merged 7 commits into from
Oct 12, 2023
Merged

More prover fixes + added rules #236

merged 7 commits into from
Oct 12, 2023

Conversation

ChaoticWalrus
Copy link
Contributor

No description provided.

@ChaoticWalrus ChaoticWalrus marked this pull request as draft October 11, 2023 23:20
@ChaoticWalrus
Copy link
Contributor Author

Currently seeing failures in the totalSharesGeqSumOfShares rule due to changes in the behavior of the StrategyManager contract -- specifically, the addShares and withdrawSharesAsTokens functions appear to be breaking this rule as currently defined.
In all likelihood, this rule needs to be totally redesigned, to capture the wider "system" nature of this property, as these logic changes mean the DelegationManager is now also key to enforcing this property.

@ChaoticWalrus
Copy link
Contributor Author

Going to merge this pure-improvement PR. I'll try to sort out the failures I'm seeing in the now ill-defined totalSharesGeqSumOfShares in another PR 😄

@ChaoticWalrus ChaoticWalrus marked this pull request as ready for review October 12, 2023 21:05
@ChaoticWalrus ChaoticWalrus merged commit cfba374 into master Oct 12, 2023
7 of 11 checks passed
@ChaoticWalrus ChaoticWalrus deleted the more-prover-fixes branch October 12, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChaoticWalrus