added check for validator balance update against withdrawable epoch #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gpsanant note that this changes the EP constructor |
Comment on lines
75
to
78
| 32e9, | ||
| 75e7 | ||
| 75e7, | ||
| 1616508000 | ||
| ) |
There was a problem hiding this comment.
seems like a good opportunity for named parameter syntax (having a few integer args in a row, could be easy to confuse these)
There was a problem hiding this comment.
Is this script still in commission?
ChaoticWalrus
approved these changes
Oct 10, 2023
gpsanant
reviewed
Oct 10, 2023
gpsanant
reviewed
Oct 10, 2023
wadealexc
approved these changes
Oct 10, 2023
gpsanant
reviewed
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @gpsanant 👍
Possible bug in eigenpods:
eigenlayer-contracts/src/contracts/pods/EigenPod.sol
Line 208 in 05e754d
A validator withdraws fully but doesn't prove their withdrawal, a balance update can be proven to bring their balance to 0. You should ideally only be able to prove the full withdrawal once the validator is withdrawn.
This PR addresses this issue by adding a check that only allows balance updates from before withdrawable epoch is set: https://github.com/ethereum/consensus-specs/blob/dev/specs/capella/beacon-chain.md#is_fully_withdrawable_validator