-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added check for validator balance update against withdrawable epoch #230
Conversation
@gpsanant note that this changes the EP constructor |
32e9, | ||
75e7 | ||
75e7, | ||
1616508000 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a good opportunity for named parameter syntax (having a few integer args in a row, could be easy to confuse these)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this script still in commission?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems technically correct, would appreciate just a little more polish prior to merging -- pointed out a couple nits I'd like to see addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending G and J feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
From @gpsanant 👍
Possible bug in eigenpods:
eigenlayer-contracts/src/contracts/pods/EigenPod.sol
Line 208 in 05e754d
A validator withdraws fully but doesn't prove their withdrawal, a balance update can be proven to bring their balance to 0. You should ideally only be able to prove the full withdrawal once the validator is withdrawn.
This PR addresses this issue by adding a check that only allows balance updates from before withdrawable epoch is set: https://github.com/ethereum/consensus-specs/blob/dev/specs/capella/beacon-chain.md#is_fully_withdrawable_validator