rename NonSignerStakesAndSignature fields to be more consistent #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the fields of NonSignerStakesAndSignature to be more consistent and added a huge comment describing how it's meant to be used above, since it was definitely the trickiest part to understand when writing an avs.
Talked to @gpsanant about this offline. This doesn't need to be merged now (since this would trickle down to a lot of needed offchain code changes), but leaving here as a suggestion, and we can merge this whenever. I personally think it would make this struct easier to understand, but I'm open to changing some of these.
Currently I followed the convention:
But we could also potentially use a
per...
suffix conventionTests
Some unit tests are failing, but I don't think it's related to my changes.