Adds fallback allowlist lookup of authenticated address #838
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mitigates a recent incident where allowlist contained a non-checksummed address for LayerN, but LayerN requests contained a checksummed address resulting in failed rateConfig lookup.
pschork
force-pushed
the
pschork/checksum_ratelimit_fallback
branch
from
ab4db13
to
4b53e54
Compare
ian-shim
reviewed
Oct 25, 2024
| @@ -326,6 +326,15 @@ func (s *DispersalServer) getAccountRate(origin, authenticatedAddress string, qu | |||
| // Check if the address is in the allowlist | |||
| if len(authenticatedAddress) > 0 { | |||
| quorumRates, ok := s.rateConfig.Allowlist[authenticatedAddress] | |||
There was a problem hiding this comment.
how about we always make the keys in this map lowercase (or checksummed) and compare with lowercased (or checksummed) addresses?
https://github.com/Layr-Labs/eigenda/blob/master/disperser/apiserver/config.go#L167-L170
There was a problem hiding this comment.
Thx for pointing this out. That's a way more systemic solution and avoids us having to normalize the allowlist configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This mitigates a recent incident where the allowlist contained a non-checksummed address for LayerN, but LayerN requests contained a checksummed address resulting in failed rateConfig lookup.
In addition to this change, we plan to normalize all rateLimit configs to use lowercase addresses enforced via blocking CI.
Checks