Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/Merge a selection of PatternClips into a single new pattern #7551

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

regulus79
Copy link
Contributor

This PR allows the user to select a group of PatternClips on the same track, rightclick, and select the option to "Copy to New Pattern Track", which will merge the selected clips into one new clip on a new PattenTrack.

Currently, this is only implemented for MidiClips, due to the limitation of PatternClips that they cannot store more than one AutomationClip or SampleClip in a row.

@bratpeki
Copy link
Contributor

So this is just a shortcut for the following:

  1. Clone track
  2. Clear track
  3. Copy relative patterns to new track
  4. Merge patterns

Am I getting it right?

@regulus79
Copy link
Contributor Author

Afaik it is not possible to merge pattern clips which have different start offsets; this pr enables that for at least the midi clips inside patterns

@asmrtfm
Copy link

asmrtfm commented Oct 20, 2024

this is a total game changer for me.

great work @regulus79 !

@bratpeki
Copy link
Contributor

I'm not getting it, sadly. Would a short video demonstration be alright?

@regulus79
Copy link
Contributor Author

Basically instead of having to manually copy/split and rearrange each midi clip, you can just rightclick and select "Copy to New Pattern Track" and however the notes in the selection of PatternClips are arranged, they will be copied and merged into a new pattern.

In your original comment, you implied that this is a shortcut for cloning and clearing a pattern track, and then copying and merging the pattern clips. In a sense this is true, but the fourth step is not currently possible in lmms. Merging pattern clips is not supported due to the way pattern clips only know what pattern index they belong to, along with their start offsets. If two clips were to be merged but they had been resized and rearranged, they would have to be represented by a whole new pattern, since they are no longer a simple integer repetition of the original pattern.

To be honest I only coded this feature because someone on the discord really wanted it. I myself don't use patterns for melodies, but I guess some people do and find a tool like this useful.

2024-10-21.14-56-41.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants