Add splitting to all types of clips

include/AutomationClipView.h

@@ -75,6 +75,7 @@ protected slots:
 
 	QStaticText m_staticTextName;
 	void scaleTimemapToFit( float oldMin, float oldMax );
+	bool splitClip(const TimePos pos) override;
 } ;
 
 

include/MidiClipView.h

@@ -103,6 +103,8 @@ protected slots:
 	QStaticText m_staticTextName;
 
 	bool m_legacySEPattern;
+
+	bool splitClip(const TimePos pos) override;
 } ;
 
 

include/PatternClipView.h

@@ -65,6 +65,8 @@ protected slots:
 	QPixmap m_paintPixmap;
 
 	QStaticText m_staticTextName;
+
+	bool splitClip(const TimePos pos) override;
 } ;
 
 

src/gui/clips/AutomationClipView.cpp

@@ -486,5 +486,53 @@ void AutomationClipView::scaleTimemapToFit( float oldMin, float oldMax )
 	m_clip->generateTangents();
 }
 
+//! Split this Clip.
+/*! \param pos the position of the split, relative to the start of the clip */
+bool AutomationClipView::splitClip(const TimePos pos)
+{
+	setMarkerEnabled(false);
+
+	const TimePos splitPos = m_initialClipPos + pos;
+
+	//Don't split if we slid off the Clip or if we're on the clip's start/end
+	//Cutting at exactly the start/end position would create a zero length
+	//clip (bad), and a clip the same length as the original one (pointless).
+	if (splitPos <= m_initialClipPos || splitPos >= m_initialClipEnd) {return false;}
+
+	m_clip->getTrack()->addJournalCheckPoint();
+	m_clip->getTrack()->saveJournallingState(false);
+
+	auto rightClip = new AutomationClip(*m_clip);
+	auto leftClip = new AutomationClip(*m_clip);
+	rightClip->clear();
+	leftClip->clear();
+
+	for(auto it = m_clip->getTimeMap().begin(); it != m_clip->getTimeMap().end(); ++it)
+	{
+		if (POS(it) >= pos)
+		{
+			rightClip->putValues(POS(it) - pos, INVAL(it), OUTVAL(it), false);
+		}
+		else
+		{
+			leftClip->putValues(POS(it), INVAL(it), OUTVAL(it), false);
+		}
+	}
+	rightClip->putValue(0, m_clip->valueAt(pos));
+	leftClip->putValue(pos, m_clip->valueAt(pos));
+
+	leftClip->changeLength(splitPos - m_initialClipPos);
+
+	rightClip->movePosition(splitPos);
+	rightClip->changeLength(m_initialClipEnd - splitPos);
+
+	// For some reason, the new clips sometime randomly put themselves in record mode. This is a temportary fix which forces them to match the original clip.
+	rightClip->setRecording(m_clip->isRecording());
+	leftClip->setRecording(m_clip->isRecording());
+
+	m_clip->getTrack()->restoreJournallingState();
+	remove();
+	return true;
+}
 
 } // namespace lmms::gui

src/gui/clips/ClipView.cpp

@@ -665,7 +665,7 @@ void ClipView::mousePressEvent( QMouseEvent * me )
 				setInitialPos( me->pos() );
 				setInitialOffsets();
 
-				if( m_clip->getAutoResize() )
+				if( m_clip->getAutoResize() && !knifeMode)
 				{	// Always move clips that can't be manually resized
 					m_action = Action::Move;
 					setCursor( Qt::SizeAllCursor );
@@ -680,7 +680,7 @@ void ClipView::mousePressEvent( QMouseEvent * me )
 					m_action = Action::ResizeLeft;
 					setCursor( Qt::SizeHorCursor );
 				}
-				else if( sClip && knifeMode )
+				else if(knifeMode)
 				{
 					m_action = Action::Split;
 					setCursor( m_cursorKnife );

src/gui/clips/MidiClipView.cpp

@@ -675,4 +675,55 @@ void MidiClipView::paintEvent( QPaintEvent * )
 }
 
 
+//! Split this Clip.
+/*! \param pos the position of the split, relative to the start of the clip */
+bool MidiClipView::splitClip(const TimePos pos)
+{
+	// Currently, due to midi clips being required to be multiples of 1 bar in length, restrict the split pos to the nearest bar:
+	const TimePos rounded_pos = (pos + TimePos::ticksPerBar() / 2) - (pos + TimePos::ticksPerBar() / 2) % TimePos::ticksPerBar();
+	setMarkerEnabled( false );
+
+	const TimePos splitPos = m_initialClipPos + rounded_pos;
+
+	//Don't split if we slid off the Clip or if we're on the clip's start/end
+	//Cutting at exactly the start/end position would create a zero length
+	//clip (bad), and a clip the same length as the original one (pointless).
+	if (splitPos <= m_initialClipPos || splitPos >= m_initialClipEnd) {return false;}
+
+	m_clip->getTrack()->addJournalCheckPoint();
+	m_clip->getTrack()->saveJournallingState(false);
+
+	auto rightClip = new MidiClip(m_clip->instrumentTrack());
+	auto leftClip = new MidiClip(m_clip->instrumentTrack());
+
+	for (Note const * note : m_clip->m_notes)
+	{
+		if (note->pos() >= rounded_pos)
+		{
+			Note *moved_note = new Note(*note);
+			moved_note->setPos(note->pos() - rounded_pos);
+			rightClip->addNote(*moved_note);
+		}
+	}
+
+	for (Note const * note : m_clip->m_notes)
+	{
+		if (note->pos() < rounded_pos)
+		{
+			leftClip->addNote(*note);
+		}
+	}
+
+	leftClip->changeLength(splitPos - m_initialClipPos);
+
+	rightClip->movePosition(splitPos);
+	rightClip->changeLength(m_initialClipEnd - splitPos);
+
+	m_clip->getTrack()->restoreJournallingState();
+	remove();
+	return true;
+}
+
+
+
 } // namespace lmms::gui

src/gui/clips/PatternClipView.cpp

@@ -195,5 +195,32 @@ void PatternClipView::update()
 	ClipView::update();
 }
 
+//! Split this Clip.
+/*! \param pos the position of the split, relative to the start of the clip */
+bool PatternClipView::splitClip(const TimePos pos)
+{
+	setMarkerEnabled(false);
+
+	const TimePos splitPos = m_initialClipPos + pos;
+
+	//Don't split if we slid off the Clip or if we're on the clip's start/end
+	//Cutting at exactly the start/end position would create a zero length
+	//clip (bad), and a clip the same length as the original one (pointless).
+	if (splitPos <= m_initialClipPos || splitPos >= m_initialClipEnd) {return false;}
+
+	m_patternClip->getTrack()->addJournalCheckPoint();
+	m_patternClip->getTrack()->saveJournallingState(false);
+
+	auto rightClip = new PatternClip(m_patternClip->getTrack());
+
+	m_patternClip->changeLength(splitPos - m_initialClipPos);
+
+	rightClip->movePosition(splitPos);
+	rightClip->changeLength(m_initialClipEnd - splitPos);
+	rightClip->setStartTimeOffset(m_patternClip->startTimeOffset() - m_patternClip->length());
+
+	m_patternClip->getTrack()->restoreJournallingState();
+	return true;
+}
 
 } // namespace lmms::gui