Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get R factor from QR factorization #288

Merged
merged 5 commits into from
May 30, 2024
Merged

Get R factor from QR factorization #288

merged 5 commits into from
May 30, 2024

Conversation

dylan-copeland
Copy link
Collaborator

No description provided.

…unique_ptr instead of raw pointers. Added a QR unit test that works in parallel.
@dylan-copeland dylan-copeland added the WIP Work in progress label May 18, 2024
@cval26 cval26 self-requested a review May 18, 2024 14:16
@dylan-copeland dylan-copeland added RFR Ready for review and removed WIP Work in progress labels May 19, 2024
Copy link
Collaborator

@ckendrick ckendrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but test_QR should probably get added to the CI.

@dylan-copeland dylan-copeland merged commit c0949e8 into master May 30, 2024
4 checks passed
@dylan-copeland dylan-copeland deleted the qr-get-r branch May 30, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants