Minor fixes.

LLNL · May 18, 2024 · 128b83b · 128b83b
1 parent 3dd2758
commit 128b83b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/linalg/Matrix.cpp b/lib/linalg/Matrix.cpp
@@ -1124,13 +1124,13 @@ Matrix::calculateNumDistributedRows() {
 std::unique_ptr<Matrix> Matrix::qr_factorize() const
 {
     std::vector<Matrix*> QR;
-    qr_factorize(true, QR);
+    qr_factorize(false, QR);
     return std::unique_ptr<Matrix>(QR[0]);
 }
 
 void Matrix::qr_factorize(std::vector<std::unique_ptr<Matrix>> & QR) const
 {
-    std::vector<Matrix*> QRraw;
+    std::vector<Matrix*> QRraw;  // Raw pointers
     qr_factorize(true, QRraw);
     QR.clear();
     for (int i=0; i<2; ++i)

diff --git a/unit_tests/test_QR.cpp b/unit_tests/test_QR.cpp
@@ -121,8 +121,6 @@ TEST(QRfactorizeTest, Test_QR)
 
     EXPECT_NEAR(maxError, 0.0, 1.0e-15);
 
-    if (rank > 0) return;
-
     EXPECT_EQ(R->numRows(), num_columns);
     EXPECT_EQ(R->numColumns(), num_columns);