Move ItemCollection and derived classes to core #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nselliott
requested review from
cyrush,
BradWhitlock,
kennyweiss,
rhornung67,
gunney1 and
agcapps
kennyweiss
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Thanks @nselliott
Please update the RELEASE_NOTES with this change.
Should add some unit tests to core for basic operations on these classes?
| @@ -222,7 +220,7 @@ class MapCollection : public ItemCollection<T> | |||
| const std::string& getItemName(IndexType idx) const | |||
| { | |||
| return (hasItem(idx) ? m_items[static_cast<unsigned>(idx)]->getName() | |||
There was a problem hiding this comment.
@nselliott -- This function requires the templated type T to have a getName() function.
Could you please document this requirement?
Alternatively, is there a way to conditionally include this function via enable_if ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving these header-only classes required removing their dependencies on Slic, as there were a few uses of Slic assertions and warnings. Those have been replaced with raw assert() calls and output to std::cerr, matching what is done elsewhere in Axom core.
The definitions of constants InvalidIndex and InvalidName needed to be moved from Sidre into core for usage by the collection classes.