Adding options to reduce prints #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu15
reviewed
Aug 4, 2023
ats/machines.py
Outdated
| @@ -317,7 +317,8 @@ def testEnded(self, test, status): | |||
| #note test.status is not necessarily status after this! | |||
| #see test.expectedResult | |||
|
|
|||
| self.noteEnd(test) #to be defined in children | |||
| if not configuration.options.removeEndNote: | |||
| self.noteEnd(test) #to be defined in children | |||
There was a problem hiding this comment.
I don't think this is correct because some machines (slurm, flux, and I think lsf) use noteEnd to calculate the number of remaining resources. The implementations of noteEnd need to be refactored to remove the print portion (perhaps as logEnd).
There was a problem hiding this comment.
you are correct Ben. That needs fixed.
dawson6
requested changes
Aug 4, 2023
liu15
reviewed
Aug 8, 2023
ats/machines.py
Outdated
| if not configuration.options.removeEndNote: | ||
| self.noteEnd(test) #to be defined in children | ||
| print(endNote) |
There was a problem hiding this comment.
Can you protect this with an
if endNote:
so that if noteEnd does not return a string, nothing is printed?
There was a problem hiding this comment.
Yes, I can do that. Was also working on a print for ATS' flux module to be consistent with the other schedulers.
liu15
approved these changes
Aug 10, 2023
dawson6
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two options:
--removeStartNoteand--removeEndNoteremoveStartNote: removes the logStart() call from step(). This gets rid of the "Start" message automatically printed by ATS
removeEndNote: removes the noteEnd() call from testEnded(). This gets rid of the "Stop" message automatically printed by ATS
Additionally, this PR adds a message printed at the end of tests when they are run using flux, to be consistent with the other schedulers.