Better compass support #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no guarantee that 'tokens' is a single value here, so it needs to be wrapped in a tuple.
The separator is a text string signifying what to use, not the actual separator itself.
The append function, unlike join, always add a single item to the end of the list, even if that new item is already a list.
That is, some dependent functions require being able to use 'in' on the result, so returning just a NumberValue is not good.
This function checks if each value in the list is 'not in' the rejection list. However, the rejection parameter was never guaranteed to be a list-type.
The dictionary in a ListValue class is in the value member, not itself.
I only say "temporarily", because quotes could be escaped, and then there could be an odd number of them. This might need a real parser instead.
|
@QuLogic, do you think we could get in touch via email or a live chat? I'm working towards improving pyScss in several areas and I'm interested in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits clean up various things, and help shape up the support for Compass.
Besides minor whitespace and sorting issues, this gets most of the samples working fairly close to the Ruby version.
There are a couple problems for which I don't have a great answer yet, and I've filed issues for those here (#59 and #61).