Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters error #3142

Closed
wants to merge 1 commit into from

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Oct 7, 2024

I ran out of funding. Suggest we get this fix in now. Then, fix shader rebuild bug and debug test later.
Tracked:
#3140
#3141

Context

When calling the static mapper vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters, there is an error because the "class" does not have a publicAPI with a modified() function.

Results

Does not error now when calling vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

which is called by macros.js object setter macro
@PaulHax
Copy link
Collaborator Author

PaulHax commented Oct 7, 2024

Superseded by #3143

@PaulHax PaulHax closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant