Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: arc paths were stored as straight line paths #4310

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

adamchalmers
Copy link
Collaborator

Problem 1 of #4297

Copy link

qa-wolf bot commented Oct 25, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app 🛑 Canceled (Inspect) Oct 25, 2024 10:10pm

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.79%. Comparing base (ca10211) to head (afebe8b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/executor.rs 47.82% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4310      +/-   ##
==========================================
- Coverage   85.80%   85.79%   -0.02%     
==========================================
  Files          77       77              
  Lines       27189    27211      +22     
==========================================
+ Hits        23330    23345      +15     
- Misses       3859     3866       +7     
Flag Coverage Δ
wasm-lib 85.79% <55.55%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamchalmers adamchalmers enabled auto-merge (squash) October 25, 2024 22:48
@adamchalmers adamchalmers merged commit 39d76ed into main Oct 25, 2024
30 of 32 checks passed
@adamchalmers adamchalmers deleted the achalmers/proper-length-calculations branch October 25, 2024 22:49
@lf94 lf94 mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants