Fix fontFamily being set to undefined #252
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for an
instanceof
OrderedElement
for thefontFamily
StringHandler
helper function.There was a check if the value passed was an Array, Object or String. When it was an Object it keys were accessed directly. But Objects of type
OrderedElement
have a different shape. I added a check if it was of typeOrderedElement
and so go about using it's getter functionOrderedElement.get()
otherwise just on the object directly.