Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tau es #18

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Tau es #18

wants to merge 11 commits into from

Conversation

conformist89
Copy link
Member

Tau energy scale adaptations

@harrypuuter
Copy link
Contributor

I think we should merge the py3 branch into master first, an then add this branch

@harrypuuter
Copy link
Contributor

This PR needs to be updated for py3 and black

@harrypuuter
Copy link
Contributor

are these changes still required ?

@conformist89
Copy link
Member Author

Sorry for the late response, I used the old version of Dumbledraw for tau ID+es corrections, I think these changes might provoke some conflicts. I can check if it's a case and then we can merge them. Does this solution work?

@harrypuuter
Copy link
Contributor

yes, since this branch is now more then 2 years old, you may want to start from the main branch again and just cherry-pick this commit: 4a67718 to see if this already covers all your required changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrypuuter harrypuuter Awaiting requested review from harrypuuter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conformist89 @harrypuuter