-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: FortranNamelists v1.0.0 #117210
base: master
Are you sure you want to change the base?
New package: FortranNamelists v1.0.0 #117210
Conversation
JuliaRegistrator
commented
Oct 13, 2024
- Registering package: FortranNamelists
- Repository: https://gitlab.com/seamsay/FortranNamelists.jl
- Created by: https://gitlab.com/seamsay
- Version: v1.0.0
- Commit: 40fe999635e59c6177759877b89d1137da0135c6
- Git reference: release
UUID: c4613040-42d1-4f07-983d-2f647aced9d0 Repo: https://gitlab.com/seamsay/FortranNamelists.jl.git Tree: 8b635c8c31a235a53639881392c8a0c9c27d3e51 Registrator tree SHA: 191228b6dd8b9d0e2965ae3e705fe54c51dcfee8
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines are all met! ✅Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
Can you clarify the relationship between this and #117266? Cf. #117266 (comment) |
@goerz Seems we were both unaware that the other was working on something 😅 I'll take a little look at that PR over the weekend and see if I can get a better understanding of what has been done in that package. |
@Sean1708 Thanks for taking a look at our package. If you could parse all the namelist files in https://github.com/anchal-physics/FortranNamelistParser.jl/tree/main/test/data by running a test similar to https://github.com/anchal-physics/FortranNamelistParser.jl/blob/main/test/file_io_tests.jl , then that should cover all our requirements and I will withdraw my PR in favor of yours. Last time I tried it, using the |