Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first attempt at artifacts #60

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

first attempt at artifacts #60

wants to merge 1 commit into from

Conversation

CarloLucibello
Copy link
Member

The download is not lazy at the moment, I don't understand how to lazily download multiple files.

Even if that is fixed, I don't see a clear advantage over current DataDeps implementation so not sure this is worth doing

@CarloLucibello CarloLucibello marked this pull request as draft March 30, 2021 08:37
@racinmat
Copy link
Contributor

On clear advantage: having this as artifact using Artifacts means it does not download directly, but it goes through the julia package server. When someone is using firewall and package server is whitelisted there, data downloaded through Artifacts go through that, so that's good, but using datadeps means it's downloading data directly, not going through the package server.
Multiple files can be downloaded by having it as multiple artifacts, see e.g. here: https://github.com/JuliaTime/TimeZones.jl/blob/master/Artifacts.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants