revert AbstractTriangular -> UpperLowerTriangular on released versions #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 86.49% 78.62% -7.87%
==========================================
Files 10 10
Lines 1740 1703 -37
==========================================
- Hits 1505 1339 -166
- Misses 235 364 +129
☔ View full report in Codecov by Sentry. |
|
Gentle bump @dlfivefifty |
dkarrasch
reviewed
Aug 5, 2023
| @@ -52,13 +52,10 @@ else | |||
| const CNoPivot = NoPivot | |||
| end | |||
|
|
|||
| if VERSION ≥ v"1.11.0-DEV.21" | |||
| using LinearAlgebra: UpperOrLowerTriangular | |||
| @static if VERSION ≥ v"1.11.0-DEV.21" | |||
There was a problem hiding this comment.
For testing purposes, could you try
Suggested change
| @static if VERSION ≥ v"1.11.0-DEV.21" | |
| @static if VERSION ≥ v"1.10-" |
and then revert? What's the breakage actually? Is it that some packages need AbstractTriangular beyond UpperOrLowerTriangular?
There was a problem hiding this comment.
It caused a bunch of ambiguities but these have been fixed downstream. I’m not sure it’s worth merging this anymore
|
I think the ship has sailed on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the current breakages