Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove warning that is no longer relevant #595

Merged
merged 2 commits into from
Sep 14, 2024
Merged

remove warning that is no longer relevant #595

merged 2 commits into from
Sep 14, 2024

Conversation

JonasIsensee
Copy link
Collaborator

@JonasIsensee JonasIsensee commented Sep 10, 2024 •
edited
Loading

closes #594

@JonasIsensee JonasIsensee changed the base branch from master to dev September 10, 2024 07:00
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (e207167) to head (436c675).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #595      +/-   ##
==========================================
- Coverage   85.19%   85.19%   -0.01%     
==========================================
  Files          36       36              
  Lines        4391     4390       -1     
==========================================
- Hits         3741     3740       -1     
  Misses        650      650

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasIsensee JonasIsensee merged commit 1181798 into dev Sep 14, 2024
16 checks passed
JonasIsensee added a commit that referenced this pull request Sep 18, 2024
@JonasIsensee
v0.5.2 (#598)
b54623f 
* remove warning that is no longer relevant (#595)

* only warn for anon functions (#597)

* only warn for anon functions

* compat for v1.6

* can't test for warning if warning is removed

* improve test

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonasIsensee @JuliaRegistrator