Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reconstruction with unknown type param #521

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

JonasIsensee
Copy link
Collaborator

closes #506

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ad988ca) 85.72% compared to head (fc6b77a) 86.46%.

Files Patch % Lines
src/data/reconstructing_datatypes.jl 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   85.72%   86.46%   +0.73%     
==========================================
  Files          31       31              
  Lines        4246     4247       +1     
==========================================
+ Hits         3640     3672      +32     
+ Misses        606      575      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasIsensee JonasIsensee merged commit 28b2185 into master Jan 4, 2024
14 of 15 checks passed
@giordano giordano deleted the reconstructionfix branch February 1, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dict of mutable struct reconstruction fails with newer JLD2 versions
1 participant