Remove attempt to be smart with company completion #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just causes issues as seen with JuliaEditorSupport#188 (comment). If you're choosing to install a fairly dramatic departure from standard emacs completion like `company`, you can't expect things like `julia-mode` to go out of their way to accomodate the ways `company` breaks normal emacs completion. The alternative would be to instead manually check `tab-always-indent` within `julia--company-indent-for-tab-command`, but I still feel like this would cause more confusion than it cures.
tpapp
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just causes issues as seen with #188 (comment). If you're choosing to install a fairly dramatic departure from standard emacs completion like
company, you can't expect things likejulia-modeto go out of their way to accomodate the wayscompanybreaks normal emacs completion.The alternative would be to instead manually check
tab-always-indentwithinjulia--company-indent-for-tab-command, but I still feel like this would cause more confusion than it cures.