Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (try) links to Try PureScript demo for web recipes #195

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

milesfrain
Copy link
Collaborator

@milesfrain milesfrain commented Aug 3, 2020

See table here: https://github.com/milesfrain/purescript-cookbook/blob/try-links/README.md#recipes

We can include some additional refinements to control whether to generate these links depending on whether the recipe is actually compatible with the try purescript environment.

Related to: purescript/trypurescript#187

@milesfrain
Copy link
Collaborator Author

@JordanMartinez
Copy link
Owner

JordanMartinez commented Aug 3, 2020

Very nice!

I tried the above link and got this error:

bad result. Likely communication issue with compiler: POST compile response failed to decode: 
There was a problem making the request: AJAX request failed: POST https://compile.purescript.org/compile

@milesfrain
Copy link
Collaborator Author

I can't reproduce that compiler error. Could you try again, and if the issue persists, could we setup a screen share meeting for troubleshooting?

@JordanMartinez
Copy link
Owner

JordanMartinez commented Aug 3, 2020 via email

@JordanMartinez
Copy link
Owner

Nevermind. Turns out a browser extension (Privacy Badger in this case) was blocking the request.

@JordanMartinez JordanMartinez merged commit dff6a1a into JordanMartinez:master Aug 3, 2020
@thomashoneyman
Copy link

Nevermind. Turns out a browser extension (Privacy Badger in this case) was blocking the request.

That may be worth adding to the error message (a privacy extension may be blocking the request), as these extensions are increasingly common and strict.

@milesfrain milesfrain deleted the try-links branch August 3, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants