fix: QRscan errors on float data; deserialization failed on unaligned data #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
Wallet produces corrupted floating point data when scanning a transaction QR
✅ Checklist
WARNING: I have tested these changes in another repository; however this repo does not build for me (flutter pub version solving failed).
🕵️♂️ Notes for Code Reviewer
🙈 Screenshots
Here is an example transaction QR code with floating point field (Weighting) which gives the error
Note: this fix is pushed upstream at primes-network/eosdart#46