New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kill-port with port-claim #7518

Merged

andrey-skl merged 1 commit into master from replace-kill-port-with-port-claim

Jul 10, 2024

Contributor

vkrol commented Jul 10, 2024 •

edited

Loading

port-claim doesn't have the following drawbacks:

It takes too long to kill with version 2.0 tiaanduplessis/kill-port#61 (<1 second vs. 16 seconds)
kill-port makes too much noise tiaanduplessis/kill-port#77 (if the port is free, there will be no useless output to the console):

Error: No process running on port

    at /Users/veniamin.krol/Projects/JetBrains/ring-ui/node_modules/kill-port/index.js:40:49


Replace kill-port with port-claim

bbf9ad7

vkrol requested review from andrey-skl and Hypnosphi

July 10, 2024 15:11

vkrol marked this pull request as ready for review

July 10, 2024 15:12

andrey-skl approved these changes

View reviewed changes

andrey-skl merged commit 925a785 into master

4 checks passed

andrey-skl deleted the replace-kill-port-with-port-claim branch

July 10, 2024 15:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment