Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changes for inmemory backend with Janusgraph 0.5.0 upgrade #4630

Conversation

FieteO
Copy link
Contributor

@FieteO FieteO commented Aug 14, 2024


Update changelog to contain update instructions for changes to in-memory backend introduced with 0.5.0.

Fixes #4532

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • [x ] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Copy link

linux-foundation-easycla bot commented Aug 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: FieteO / name: Fiete (82e91c7)

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Aug 14, 2024
Fixes JanusGraph#4532

Signed-off-by: Fiete Ostkamp <F.Ostkamp@web.de>
@FieteO FieteO force-pushed the 4532-050-inmemory-upgrade-instructions-in-changelog branch from 8a4768c to 82e91c7 Compare August 14, 2024 19:16
Copy link
Member

@FlorianHockmann FlorianHockmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the contribution!

Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @FieteO !

@porunov porunov merged commit 56aa0d0 into JanusGraph:master Aug 16, 2024
76 checks passed
@porunov porunov added this to the Release v1.1.0 milestone Aug 16, 2024
@janusgraph-automations
Copy link

💚 All backports created successfully

Status Branch Result
v1.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.5.0 upgrade instructions do not mention removal of inmemory backend from janusgraph-core
5 participants