-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES Bulk Retry Follow-up Items #4530
ES Bulk Retry Follow-up Items #4530
Conversation
@li-boxuan & @porunov follow-up PR as requested 👍 |
da5c1cf
to
c3e646e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @criminosis ! I have just some small nitpicks regarding tiny optimizations
janusgraph-es/src/main/java/org/janusgraph/diskstorage/es/rest/RestElasticSearchClient.java
Outdated
Show resolved
Hide resolved
janusgraph-es/src/main/java/org/janusgraph/diskstorage/es/rest/RestElasticSearchClient.java
Outdated
Show resolved
Hide resolved
- Reference the ElasticSearch documentation in the bulk chunker size limit config option - Cleaning up the population of the ES bulk request path logic - Submitting bulk request items that are below the configured limit, then throwing for overly large items Signed-off-by: Allan Clements <criminosis@gmail.com>
c3e646e
to
bb48e63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @criminosis for a quick follow up PR!
@li-boxuan maybe worth your attention too since one of the follow-ups was your request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you!
Closes #4529
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: