Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES Bulk Retry Follow-up Items #4530

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

criminosis
Copy link
Contributor

Closes #4529

  • Reference the ElasticSearch documentation in the bulk chunker size limit config option
  • Cleaning up the population of the ES bulk request path logic
  • Submitting bulk request items that are below the configured limit, then throwing for overly large items

Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@criminosis
Copy link
Contributor Author

@li-boxuan & @porunov follow-up PR as requested 👍

Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @criminosis ! I have just some small nitpicks regarding tiny optimizations

@porunov porunov added this to the Release v1.1.0 milestone Jun 25, 2024
- Reference the ElasticSearch documentation in the bulk chunker size limit config option
- Cleaning up the population of the ES bulk request path logic
- Submitting bulk request items that are below the configured limit, then throwing for overly large items

Signed-off-by: Allan Clements <criminosis@gmail.com>
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @criminosis for a quick follow up PR!

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Jun 27, 2024
@criminosis
Copy link
Contributor Author

@li-boxuan maybe worth your attention too since one of the follow-ups was your request?

Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you!

@li-boxuan li-boxuan merged commit a3393a1 into JanusGraph:master Jun 28, 2024
175 checks passed
@criminosis criminosis deleted the es_retry_follow_up_items branch July 10, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/skip cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES Bulk Retry Follow-up Items
4 participants