Speed Bench #32
Merged
Speed Bench #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some very simple speed benchmarks, which generate graphs of time vs num_steps and time vs dimensions. Should probably be done with more runs, for stability. This can be used to check that code changes haven't caused major slowdowns, but benchmarking on the master branch compared to the new branch before merging. (In theory, one could automate this, and e.g. have github run the code on its server and prevent statistically significant slowdowns from being merged, but there's no reason to spend too much time on this - a manual solution is fine).