Tests

[reubenharry]

I think a basic thing the tests should do is run every configuration of the sampler that we expect to work in general. This way, we make sure that nothing breaks whenever we commit new code.

For example, in the tests, I run:

sampler.sample(20, 3, output='ess')
sampler.sample(20, 3, output='expectation')
sampler.sample(20, 3, output='detailed')
sampler.sample(20, 3, output='normal')

This already reveals that 'expectation' and 'ess' are not currently working on the master branch. (@JakobRobnik , should they be? If not, we should just remove them, and if so, we should fix them).

I haven't added similar code to test the annealing, ensemble or other samplers, but we should also do that soon.

[JakobRobnik]

I agree, this sounds like a good plan. They should work, will fix this.

…

On Sat, Oct 14, 2023 at 5:32 PM Reuben ***@***.***> wrote: I think a basic thing the tests should do is run every configuration of the sampler that we expect to work in general. This way, we make sure that nothing breaks whenever we commit new code. For example, in the tests, I run: sampler.sample(20, 3, output='ess')sampler.sample(20, 3, output='expectation')sampler.sample(20, 3, output='detailed')sampler.sample(20, 3, output='normal') This already reveals that 'expectation' and 'ess' are not currently working on the master branch. ***@***.*** <https://github.com/JakobRobnik> , should they be? If not, we should just remove them, and if so, we should fix them). I haven't added similar code to test the annealing, ensemble or other samplers, but we should also do that soon. ------------------------------ You can view, comment on, or merge this pull request online at: #25 Commit Summary - 83aefe9 <83aefe9> tests - 6be4b14 <6be4b14> tests File Changes (1 file <https://github.com/JakobRobnik/MicroCanonicalHMC/pull/25/files>) - *M* tests/test_mclmc.py <https://github.com/JakobRobnik/MicroCanonicalHMC/pull/25/files#diff-d5e7c195aa84036b6d214015265c4494caade7baa22e62c482b8b0ee4f34b6db> (34) Patch Links: - https://github.com/JakobRobnik/MicroCanonicalHMC/pull/25.patch - https://github.com/JakobRobnik/MicroCanonicalHMC/pull/25.diff — Reply to this email directly, view it on GitHub <#25>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKIPD4BE2IZ2KNZCMCESBW3X7KWALAVCNFSM6AAAAAA6AKPS6CVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DGMZTG44DGMY> . You are receiving this because you were mentioned.Message ID: ***@***.***>