Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix Issue Unable to remove multiline property from field #12039

Closed
wants to merge 2 commits into from

Conversation

PressJump
Copy link

@PressJump PressJump commented Oct 20, 2024

This pull request aims to fix the issue where the user is unable to remove a multi-line property from fields. This is done through the addition of a checkbox listener that also checks the multiline boxes in other entry types as they are by design global Ref: #11897 (comment). This not only gives visual feedback of the change to the user but also fixes the issue without refactoring CustomEntryTypesTabViewModel logic as the original issue stemmed from the for-loop inside storeSettings overriding boolean changes which was also originally mentioned in the issue.

To remove the multiline setting, I have to update it for all entry types.

#11897 (comment)

Setting the value of the field in all entry types utilizes this to fix the issue.

fields-jabref

Closes #11897

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@PressJump PressJump marked this pull request as draft October 20, 2024 07:03
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

You can check review dog's comments at the tab "Files changed" of your pull request.

@PressJump
Copy link
Author

Source branch is required to be other than Main to follow contribution guidelines at https://devdocs.jabref.org/contributing. Closing pull request per comment.

@PressJump PressJump closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry types preferences: Unable to remove multiline property from field
1 participant