Hypha #45
Merged
Hypha #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
force-pushed
the
hypha
branch
2 times, most recently
from
ad0e04b
to
67815b4
Compare
|
👍 |
PaulHax
commented
Jul 20, 2023
Comment on lines
36
to
39
| const p = new Promise((resolve) => setTimeout(resolve, 5000)); | ||
| p.then(() => { | ||
| this.remote.send({ type: 'render' }); | ||
| }); |
PaulHax
commented
Jul 20, 2023
| @@ -0,0 +1,9 @@ | |||
| declare namespace hyphaWebsocketClient { | |||
thewtex
approved these changes
Jul 20, 2023
| @@ -54,7 +58,7 @@ export const viewportMachine = createMachine({ | |||
| context.cameraSubscription.unsubscribe(); | |||
| context.cameraSubscription = context.camera?.subscribe( | |||
| (state) => { | |||
| self.send({ | |||
| (self as ActorRef<SetCameraEvent | SetCameraPoseEvent>).send({ | |||
There was a problem hiding this comment.
I remember now what SetCameraPoseEvent does and added this comment:
Let observers of Viewport know that camera has updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.