Skip to content

Commit

Permalink
fix(itk-remote-viewport): remove orphaned image attribute (#69)
Browse files Browse the repository at this point in the history
  • Loading branch information
PaulHax authored Sep 21, 2023
1 parent 4b82a23 commit bd7b09f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
6 changes: 6 additions & 0 deletions .changeset/cold-dolphins-collect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@itk-viewer/element': patch
'@itk-viewer/remote-viewport': patch
---

Bump remote-viewport publish
2 changes: 1 addition & 1 deletion packages/element/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
<script type="module" src="/src/itk-viewer-element.ts"></script>
<script type="module" src="/src/main.ts"></script>
</head>

<body>
<itk-viewer>
<itk-remote-viewport
id="right-viewport"
server-config='{ "serverUrl": "%VITE_HYPHA_URL%", "serviceId": "%VITE_HYPHA_RENDER_SERVICE_ID%" }'
image="%VITE_IMAGE%"
></itk-remote-viewport>
</itk-viewer>
</body>
Expand Down
7 changes: 2 additions & 5 deletions packages/element/src/itk-remote-viewport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ import {
RemoteActor,
createHyphaActors,
createRemoteViewport,
Image,
} from '@itk-viewer/remote-viewport/remote-viewport.js';

import type { Image } from '@itk-viewer/remote-viewport/remote-viewport.js';

import { ItkViewport } from './itk-viewport.js';
import './itk-camera.js';

Expand All @@ -20,9 +21,6 @@ export class ItkRemoteViewport extends ItkViewport {
@property({ type: Object, attribute: 'server-config' })
serverConfig: unknown | undefined;

@property({ type: String })
image: string | undefined;

@property({ type: Number })
density = 30;

Expand Down Expand Up @@ -144,7 +142,6 @@ export class ItkRemoteViewport extends ItkViewport {
return html`
<h1>Remote viewport</h1>
<p>Server Config: ${JSON.stringify(this.serverConfig)}</p>
<p>Image: ${this.image}</p>
<div>
Density: ${this.density}
<input
Expand Down

0 comments on commit bd7b09f

Please sign in to comment.