feat: multiple auth methods for identities #2606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
force-pushed
the
daniel/multiple-auth-methods
branch
2 times, most recently
from
db8f6e9
to
b823ffd
Compare
akhilmhdh
requested changes
Oct 21, 2024
| .select("id") | ||
| .from(TableName.Identity) | ||
| .whereRaw(`${TableName.IdentityAccessToken}."identityId" = ${TableName.Identity}.id`) | ||
| .whereNotNull("authMethod"); |
There was a problem hiding this comment.
I am bit confused by this whereNotNull. Because its with no auth method set right?
There was a problem hiding this comment.
Also i don't think there will be access token with unconfigured identity. It will have an auth method right to get a token
...MembersPage/components/OrgIdentityTab/components/IdentitySection/IdentityAuthMethodModal.tsx
Outdated
Show resolved
Hide resolved
DanielHougaard
force-pushed
the
daniel/multiple-auth-methods
branch
from
90a9e36
to
1e087ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR implements support for adding multiple auth methods to an identity. It only supports adding different auth methods, you cannot add two of the same auth methods.
This initiative brings no breaking changes.
Minor
Additionally I've made an improvement to the generate schema script. It now also runs eslint fix after generating the new schemas, so we don't have to manually fix the schemas after generation.
Fixed a typo that's been present in the backend for a while.
IdentityAuthMethods.Univarsalhad a typo and improper casing, it's now namedIdentityAuthMethods.UNIVERSAL_AUTHType ✨
Tests 🛠️
# Here's some code block to paste some code snippets