-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EOL related build issues on Windows #2077
base: main
Are you sure you want to change the base?
Conversation
Build checks have not completed. Possible reasons for this are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. No change in behavior on supported platforms (i.e. Linux) and possible fix for Windows builds. Just suggesting a few comments for future "us" to know why we don't have native line endings
only affects windows users
add reminder why this is necessary directly to file Co-authored-by: NeroBurner <pyro4hell@gmail.com>
f06149e
to
a44d00a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. I'm scheduling for 1.16.0 as 1.15.0 feels close
Proper fix for #1275 that does no longer require manual intervention.
On Windows, git has
core.autocrlf=true
set at system level, hence any Windows user who has not changed their global git config will checkout all text files with CRLF line endings. For some files this seems to cause build issues.With this change, I can build using docker on Windows 11 as follows:
Without the change, the build fails with an error that matches the one described in #1275:
Note: when changing between branches with varying
.gitattributes
withcheckout
instead of directly cloning with--branch
, resetting the line endings is more complicated: