Implement new hardware abstraction from InfiniTime using C++20 concepts. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeroBurner
requested changes
Oct 23, 2022
NeroBurner
added
the
needs-InfiniTime-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new hardware abstraction from InfiniTimeOrg/InfiniTime#1387.
Notice that the C++ standard was upgraded from 17 to 20.
InfiniTime now defines an "interface" for the drivers (only Spi, SpiMaster and SpiNorFlash are modified right now). The application (InfiniTime / InfiniSim) must inject an actual implementation for the driver. This allows InfiniSim to inject its own implementation into the interface, instead of having to provide an alternative version of the same class (same name, same namespace, same constructor). This will probably allow to remove a lot of redefinitions and copy/paste InfiniSim had to make to implement the current drivers.