Add support for common XSD data types in attributes #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brunato ^ |
|
I was also not succeeding in getting the sample SP and IdP implementation of DjangoSAML2IdP working (here: https://github.com/OTA-Insight/djangosaml2idp/tree/master/example_setup). I pulled these changes by @fontoura locally and they do really fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default attribute converter used by PySAML2 does read all attributes as strings. This breaks Django sample projects with SP (https://github.com/peppelinux/djangosaml2) and IdP (https://github.com/OTA-Insight/djangosaml2idp) since boolean user attributes are expected to be either True or False in Python, but are rendered as "true" and "false".
I added a code which checks the
{http://www.w3.org/2001/XMLSchema-instance}typeattribute on the AttributeValue tags, and converts the values accordingly (my current implementation suppots numbers and booleans only).