This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
Attach extra token response claims as property on user object #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvendrame
suggested changes
Jun 2, 2021
| @@ -53,7 +54,8 @@ export class User { | |||
| token_type: this.token_type, | |||
| scope: this.scope, | |||
| profile: this.profile, | |||
| expires_at: this.expires_at | |||
| expires_at: this.expires_at, | |||
| ...this.otherClaims | |||
There was a problem hiding this comment.
It should be ...this.otherValues, as the constructor is storing the value in this property
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the amazing work on this library. I'm hoping this change can make it in quickly!
I'm using this library against a service implementing the SMART on FHIR OAuth extension. Upon signin, the token response has a few extra parameters that are passed to this library's
Userconstructor, but they aren't stored anywhere. I've looked closely and there doesn't seem to be a good way to read these properties short of reimplementing most ofUserManager. As such I've modified the constructor to store these additional fields asotherClaims.