Apply nodeSelector, affinity and tolerations in Deployment #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n deployment.yaml and bump version. Signed-off-by: Bing Steup <b.steup@rekenkamer.nl>
|
LGTM. Thanks! It will be included in chart v0.3.0. |
alexnuttinck
approved these changes
Jun 14, 2024
alexnuttinck
added a commit
that referenced
this pull request
Jun 14, 2024
commit 15fe0dc Author: anuttinck <alexandre.nuttinck@imio.be> Date: Fri Jun 14 15:48:31 2024 +0200 [MOD] default initialDelaySeconds for livenessProbe and readnessProbe commit cedd97b Author: anuttinck <alexandre.nuttinck@imio.be> Date: Fri Jun 14 15:28:57 2024 +0200 [DEL] random totpVaultKey commit c7e1002 Author: anuttinck <alexandre.nuttinck@imio.be> Date: Fri Jun 14 13:50:12 2024 +0200 [ADD] livenessProbe and readinessProbe in values.yaml #11 commit 426df0d Merge: a246bbc 28c8b0d Author: anuttinck <alexandre.nuttinck@imio.be> Date: Fri Jun 14 13:17:46 2024 +0200 Merge branch 'main' of https://github.com/FyraLabs/helm-plausible-analytics into v0.3.0 commit a246bbc Author: Maxime VALETTE <maxime@maximevalette.com> Date: Fri Jun 14 13:06:33 2024 +0200 Remove deprecated db init-admin command (#15) * Remove deprecated db init-admin command https://github.com/plausible/analytics/blob/e522a2d7c182f5a0c7b2d95bf3ea248567a529e0/rel/overlays/init-admin.sh#L4-L5 * Chart version bump Signed-off-by: Maxime VALETTE <maxime@maximevalette.com> --------- Signed-off-by: Maxime VALETTE <maxime@maximevalette.com> Co-authored-by: Alexandre Nuttinck <alexandre.nuttinck@imio.be> commit 5db542b Author: Bing Steup <bingneef@users.noreply.github.com> Date: Fri Jun 14 12:33:00 2024 +0200 Feat: apply nodeSelector, affinity and tolerations from values.yaml in deployment.yaml and bump version. Signed-off-by: Bing Steup <b.steup@rekenkamer.nl> (#14) Co-authored-by: Alexandre Nuttinck <alexandre.nuttinck@imio.be> commit 198536f Author: anuttinck <alexandre.nuttinck@imio.be> Date: Fri Jun 14 12:27:17 2024 +0200 [FIX] MAILGUN_API_KEY in secrets.yaml commit 4dcebce Author: Martin Haug <mhaug@live.de> Date: Fri Jun 14 12:23:43 2024 +0200 Fix SendGrid API key secret (#13) Signed-off-by: Martin Haug <mhaug@live.de> commit 13eb40c Author: anuttinck <alexandre.nuttinck@imio.be> Date: Fri Jun 14 12:19:31 2024 +0200 Bump helm chart to 0.3.0 commit 28c8b0d Author: lleyton@fyralabs.com <lleyton@fyralabs.com> Date: Fri May 31 14:30:58 2024 -0700 chore: bump version to 0.2.5 Signed-off-by: lleyton@fyralabs.com <lleyton@fyralabs.com> commit 577df6d Author: lea <lleyton@fyralabs.com> Date: Fri May 31 14:15:26 2024 -0700 fix: add newly required totpSecretKey option commit cf8e41b Author: lea <lleyton@fyralabs.com> Date: Fri May 31 14:08:54 2024 -0700 chore: upgrade for Plausible v2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
values.yamlcontain the keysnodeSelector,affinityandtolerations. However, these are not applied in thedeployment.yaml. I have included them following the defaulthelm createtemplate.Which issue this PR fixes
None
Special notes for your reviewer:
Checklist