Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-39098 : Fix address comparison in _areSameAdresses #269

Open
wants to merge 2 commits into
base: urban2.7.x
Choose a base branch
from

Conversation

dmshd
Copy link
Contributor

@dmshd dmshd commented Oct 1, 2024

This fixes the following error.
I did it in pair @daggelpop and I reproduced the same problem with the same data locally and our code seems to resolve the problem.
Problem was if street_a was empty (tenant had no address set in the "cadastre", the tace was generated and the tenants where not properly created. See https://support.imio.be/browse/SUP-39098 for more info.

<155>Sep 19 13:25:59 urban007 zope[2243328]: lalouviere_urb25 instance2 [ERROR] Zope.SiteErrorLog | 1726745159.670.781332659531 https://lalouviere-urban.imio-app.be/urban/codt_urbancertificateones/codt_urbancertificateones/codt_urbancertificateone.2024-09-19.7151418318/searchparcels
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.urban.browser.searchparcelsview, line 74, in __call__
  Module Products.urban.browser.searchparcelsview, line 197, in createParcelAndProprietary
  Module Products.urban.browser.searchparcelsview, line 248, in createApplicantFromParcel
  Module Products.urban.browser.searchparcelsview, line 283, in _areSameAdresses
TypeError: ratio expected two Strings or two Unicodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant