-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nested flowsheet time domain construction #1495
Open
NishantGiridhar
wants to merge
10
commits into
IDAES:main
Choose a base branch
from
NishantGiridhar:fs_nested_dyn_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e778dc6
Allow construction of nested time domain from config.time_set
NishantGiridhar 8ecc4c7
Added tests for different time domains in nested flowsheets
NishantGiridhar 7855199
Added test to create nested time indexed SS flowsheet in dynamic parent
NishantGiridhar 71af0da
Add comments + remove check for dynamic sub flowsheet in SS parent fl…
NishantGiridhar 03bbc3f
Updated tests
NishantGiridhar 77c2f37
update formatting with black
NishantGiridhar 516deb9
Merge branch 'IDAES:main' into fs_nested_dyn_fix
NishantGiridhar 891b857
Sub-flowsheets with unspecified time inherit time from parent
NishantGiridhar c322abe
Fix test to use user provided time for parent flowsheet
NishantGiridhar 1b4d02b
Merge branch 'IDAES:main' into fs_nested_dyn_fix
NishantGiridhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the
[0]
here? I would have thought that if we are handed an argument we should use it. To put it another way, if the user provides[0]
as an argument we will ignore it without saying why.