Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

petsc 3.22.0 #195118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

petsc 3.22.0 #195118

wants to merge 2 commits into from

Conversation

MarDiehl
Copy link
Contributor

@MarDiehl MarDiehl commented Oct 21, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2024
@MarDiehl
Copy link
Contributor Author

Note: Due to compiler version mismatches (I have gcc14 installed which seems to be picked up by homebrew, but tests/MPI expect gcc-11), the tests fail on my system.

@MarDiehl
Copy link
Contributor Author

I'm a little bit surprised about the failing "Commit style" check. Not including petsc-complex.rb also gives a warning because petsc and petsc-complex are out of sync.

@MarDiehl
Copy link
Contributor Author

@oldsharp: I believe this is interesting for you.

Note that both formulas deviate a little, # Avoid references to cellar paths. is missing in the complex variant. Also, there is a small difference in the path used for testing.

The differences are easy to see using diff or similar tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant